Skip to content

fix(gemini): prefix Windows hook with Git Bash#2572

Open
YOMXXX wants to merge 1 commit into
rtk-ai:developfrom
YOMXXX:fix/issue-2323-gemini-windows-bash
Open

fix(gemini): prefix Windows hook with Git Bash#2572
YOMXXX wants to merge 1 commit into
rtk-ai:developfrom
YOMXXX:fix/issue-2323-gemini-windows-bash

Conversation

@YOMXXX

@YOMXXX YOMXXX commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #2323.

Summary

  • Build the Gemini hook command through a small platform helper.
  • On Windows, prefix the generated .sh hook with Git for Windows bash.exe when it can be found, quoting paths with spaces.
  • Keep non-Windows behavior as the existing bare hook script path.

Verification

  • cargo +1.93.0 test gemini_hook_command_windows -- --nocapture
  • cargo +1.93.0 test gemini -- --nocapture
  • cargo +1.93.0 fmt --all -- --check
  • cargo +1.93.0 clippy --all-targets
  • cargo +1.93.0 test --all -- --skip small_grep_not_worse_than_plain
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] rtk init -g --gemini generates broken hook command on Windows (bash path incompatibility causes flash window on every tool call)

1 participant